Update Notification interface to match correct API #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScreamZ
force-pushed
the
improve-typings
branch
from
bbe0a79 to
fbb6d69
Compare
ScreamZ
commented
Jan 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7-dev #739 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 46 46
Lines 2119 2119
Branches 410 410
=======================================
Hits 1756 1756
Misses 282 282
Partials 81 81 ☔ View full report in Codecov by Sentry. |
etrousset
approved these changes
Oct 15, 2024
|
🎉 This PR is included in version 7.14.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve document payload according to real documentation
https://docs.kuzzle.io/core/2/api/payloads/notifications/#document-notification
Can you ping me on release @rolljee @etrousset ? Thanks :)